Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent Canvas Fragment as a Geographic Area on a Web Map #183

Merged
merged 196 commits into from
Apr 2, 2021

Conversation

thehabes
Copy link
Contributor

@thehabes thehabes commented Jun 26, 2020

Files are at https://github.com/IIIF/cookbook-recipes/tree/0139-geo-annotation/recipe/0139-geolocate-canvas-fragment

Preview : https://preview.iiif.io/cookbook/0139-geo-annotation/recipe/0139-geolocate-canvas-fragment/

Issue that started this recipe is at #139

I am willing to bet the recipe ID (index and the /recipe folder name) are off, please let me know what number you actually want me to make it.

Bryan H added 30 commits April 24, 2020 13:50
…tionPage cannot have annotations. AnnotationPages can have Annotations with multiple bodies and/or differing targets.
… word of interest is targeted and geocoded.
… word of interest is targeted and geocoded.
… word of interest is targeted and geocoded.
@glenrobson
Copy link
Member

Hi Bryan,

The editors reviewed your recipe and are generally happy for it to go to the TRC but have asked for a quick review once you've made the requested changes below:

  • Could you change the:

“to associate this map with modern geocoordinates that clients can use for representing the targeted region in world based Web Maps, such as Leaflet or Google Maps”

to

"to associate this map with a geographic coordinates system. Once associated clients could use geographic coordinates to represent the targeted region in clients like Leaflet or Google Maps. "

The reason was to make this more approachable to non Geo people. They also requested to remove reference to Web Map just to avoid confusion or conflation by mentioning another Standard.

  • Move to restrictions: “When the @context property is used as an array with multiple contexts, the IIIF Presentation API 3.0 context must be the last item in the array.”
  • Could you replace the TBD in the recipes under “Related Recipes” with issue numbers? If they don't have issue numbers could you remove the related recipe.

They were happy with the switch of use case and thought it made it a lot clearer.

Thanks

Glen

@thehabes
Copy link
Contributor Author

thehabes commented Mar 9, 2021

Response to the first change suggestion
You are not just trying to associate this map with a geographic coordinates system. If that's what you're doing, GeoJSON may not be the best option. You are trying to associate the map (on a fragment of this IIIF Web resource) with WGS84 compliant coordinates for use on the Web in hopes you could view those coordinates rendered in some way on an online (Web) map like Google Maps (and maintain the connection to metadata about the IIIF Web resource). Online Web map coordinate stuff is done with GeoJSON, and any data you have that is not GeoJSON is being shimmed into GeoJSON for this purpose, which is the argument for minting those objects with GeoJSON as opposed to anything else.

As such, I can suggest something where we meet half way

  • to associate this map with WGS84 compliant coordinates for use in online mapping systems (a.k.a Web Maps). GeoJSON is the primary data format processed by online mapping systems (Web Maps), and so the geographic coordinates for the targeted region can be processed by clients (Web Maps) such as Leaflet or Google Maps

Response to second change suggestion

  • I think Web Map is the clearest pronoun. Online Mapping System, Coordinate Reference System, MapUI, Map-Based Web Application all seem much more vague to me. Web Map has become accepted vocabulary. I am reluctant to change it without very good reasoning to the contrary.

Response to third change

  • The JSON-LD 1.1 spec notes Multiple contexts may be combined using an array, which is processed in order. and places no restriction on order, since it is a @set. The IIIF Presentation API 3 restricts the freedom of where you can place the IIIF Presentation API 3 context because of its implementation demands, but otherwise places no restrictions here. This feels more like a (IIIF Presentation API 3) implementation note than a restriction, and I am reluctant to move it without more reasoning.

Sorry to be so confrontational! I am really a reasonable person and am happy to talk further about any of this.

@eliotjordan
Copy link

eliotjordan commented Mar 10, 2021

I would suggest:

"to associate this map with geographic coordinates for use in web map mapping clients like Leaflet and OpenLayers."

@thehabes
Copy link
Contributor Author

Post IIIF Maps TSG Call Feelings

  • See Elliot's new wording suggestion. Important to let people know this is for connecting with familiar web mapping clients like Leaflet, Google Maps, OpenLayers, OpenStreetMaps (pick just a couple). Not just for assigning coordinates w/o a presentation purpose.
  • Capitalized Web Maps is a main component of causing these feelings. At least lowercase it. No WGS84 that's too technical. General agreement on this change.
  • Leave it as an implementation note.

Thanks to everyone on the call today. It was extremely helpful for thinking through this. I will get these changes in.

@glenrobson
Copy link
Member

Thanks Bryan its looking good!

@glenrobson glenrobson added meta: approved-by-trc Recipe has been approved by the TRC and removed meta: approved-by-trc Recipe has been approved by the TRC labels Apr 2, 2021
@glenrobson glenrobson merged commit b3b3d65 into master Apr 2, 2021
@glenrobson glenrobson deleted the 0139-geo-annotation branch April 2, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geographic data meta: ready-for-trc Issue is ready for TRC review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Place Canvas Fragment to an Area on a Web Map
3 participants